Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent multiple html-ids in product-variation-select-component #76

Merged
merged 1 commit into from Jan 9, 2020
Merged

prevent multiple html-ids in product-variation-select-component #76

merged 1 commit into from Jan 9, 2020

Conversation

Sebastian-Haehnlein
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • CI-related changes
  • Documentation content changes
  • application / infrastructure changes
  • Other... Please describe:

What Is the Current Behavior?

Issue Number: #74

What Is the New Behavior?

no multiple html-ids

Does this PR Introduce a Breaking Change?

  • Yes
  • No

@Sebastian-Haehnlein Sebastian-Haehnlein self-assigned this Jan 6, 2020
@Sebastian-Haehnlein Sebastian-Haehnlein added the bug Something isn't working label Jan 6, 2020
@Sebastian-Haehnlein Sebastian-Haehnlein added this to the 0.16 milestone Jan 6, 2020
@shauke shauke modified the milestones: 0.16, 0.17 Jan 7, 2020
@shauke shauke merged commit 85c8cb2 into develop Jan 9, 2020
@shauke shauke deleted the bugfix/product-variations-prevent-multiple-html-ids branch January 9, 2020 09:10
@shauke shauke mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

@dhhyi dhhyi Awaiting requested review from dhhyi

Assignees

@Sebastian-Haehnlein Sebastian-Haehnlein

Labels
bug Something isn't working
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sebastian-Haehnlein @shauke