Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address countryCode and mainDivision fields behavior #819

Merged
merged 1 commit into from Aug 4, 2021

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Aug 4, 2021

PR Type

[x] Bugfix

What Is the Current Behavior?

Before, there was a bug that allowed you to submit an invalid address form when changing the country after already having selected a state/province. This is now fixed.
In addition, the country field didn't show a checkmark after selection.

What Is the New Behavior?

The mainDivisionCode is now correctly reset after a country switch.
The country field now correctly displays a checkmark when a valid value is selected.

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#65836

@MaxKless MaxKless added this to the 1.0 milestone Aug 4, 2021
@MaxKless MaxKless requested a review from SGrueber August 4, 2021 12:24
@MaxKless MaxKless self-assigned this Aug 4, 2021
@MaxKless MaxKless added this to In progress in Current via automation Aug 4, 2021
Current automation moved this from In progress to Review in progress Aug 4, 2021
@MaxKless MaxKless merged commit 5f2e70c into develop Aug 4, 2021
Current automation moved this from Review in progress to Done Aug 4, 2021
@MaxKless MaxKless deleted the bugfix/address-province-fix branch August 4, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Current
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants