Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API cleanup: Unified getter/setter approach #12

Open
Philipp-Borchert-ISH opened this issue Apr 7, 2022 · 0 comments
Open

API cleanup: Unified getter/setter approach #12

Philipp-Borchert-ISH opened this issue Apr 7, 2022 · 0 comments
Assignees
@GTaenzer
Labels
enhancement New feature or request ISH-STAFF Issues that *should* be resolved by ISH staff due to impact on IOM platform tests

Comments

@Philipp-Borchert-ISH
Copy link
Member

Philipp-Borchert-ISH commented Apr 7, 2022 •
edited

Describe the solution you'd like
Currently a lot of business objects show inconsistent usage of lombok annotations, manual getters/setters, toString implementations etc. This should be unified. During development of 4.0.0 it became obvious that not "every" combination of lombok annotations works properly with mapstruct's default mapping strategies.

Proposal: use these annotations on every class

@Getter
@Setter
@EqualsAndHashCode(callSuper = false)
@ToString
@Accessors(chain = true)

e.g. https://github.com/intershop/iom-test-framework/blob/main/src/main/java/com/intershop/oms/test/businessobject/communication/OMSReturn.java

AB#85544
@Philipp-Borchert-ISH Philipp-Borchert-ISH added enhancement New feature or request ISH-STAFF Issues that *should* be resolved by ISH staff due to impact on IOM platform tests labels Apr 7, 2022
@GTaenzer GTaenzer self-assigned this Apr 21, 2023
GTaenzer added a commit that referenced this issue Apr 24, 2023
@GTaenzer
feat: first steps to unify getters/setters (#12)
9e1cb2e
GTaenzer added a commit that referenced this issue Apr 24, 2023
@GTaenzer
feat: first steps to unify getters/setters (#12)
a68f650
GTaenzer added a commit that referenced this issue Apr 24, 2023
@GTaenzer
fixed location (#12)
d8ab5e5
GTaenzer added a commit that referenced this issue Apr 24, 2023
@GTaenzer
feat: first steps to unify getters/setters (#12)
19a6107 
Task/12 unified getter setter
GTaenzer added a commit that referenced this issue May 8, 2023
@GTaenzer
feat: unify getters/setters for OMSCharge(#12)
de2b9ff
GTaenzer added a commit that referenced this issue May 8, 2023
@GTaenzer
feat: unify getters/setters for Addresses (#12)
76bb745
GTaenzer added a commit that referenced this issue May 8, 2023
@GTaenzer
feat: unify getters/setters (#12)
240fa23
GTaenzer added a commit that referenced this issue May 9, 2023
@GTaenzer
feat: unify getters/setters (#12)
d2f9e7d
GTaenzer added a commit that referenced this issue May 10, 2023
@GTaenzer
feat: unify getters/setters (#12)
66f53bf
GTaenzer added a commit that referenced this issue May 10, 2023
@GTaenzer
Task/12 unified getter setter (#65)
8bed2eb 
* feat: unify getters/setters (#12)
GTaenzer added a commit that referenced this issue Dec 14, 2023
@GTaenzer
chore: unify Getter/Setter approach (#12)
86562ae
@GTaenzer GTaenzer mentioned this issue Dec 19, 2023
Merged
GTaenzer added a commit that referenced this issue Dec 20, 2023
@GTaenzer
Task/82 remove deprecations (#83)
0db769e 
* chore: removed deprecations (#75)

* bug: versioned import in unversioned interface (#76)

* bug: versioned import in unversioned interface (#76)

* bug: versioned import in unversioned interface (#76)

* chore: cleanup (#75)

* chore: removed sendOrder methods (#75)

* chore: removed deprecated methods renamed by lombok (#75)

* chore: removed endCrossDocking[OrderResponse|Dispatch|Return] (#82)

* chore: unify Getter/Setter approach (#12)

* chore: removed deprecated methods (#82)

* chore: removed deprecated methods (#82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GTaenzer GTaenzer

Labels
enhancement New feature or request ISH-STAFF Issues that *should* be resolved by ISH staff due to impact on IOM platform tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Philipp-Borchert-ISH @GTaenzer