Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module.xml #27

Merged
merged 1 commit into from Oct 17, 2020

Conversation

SergeyMi37
Copy link
Contributor

Description added

Description added
@nikitaeverywhere
Copy link
Member

Please also bump version/description in package.json. Thanks!

@nikitaeverywhere nikitaeverywhere merged commit 613fc4a into intersystems-community:master Oct 17, 2020
@SergeyMi37
Copy link
Contributor Author

It would be nice to make an update release in Open Exchange.

@evshvarov
Copy link
Member

evshvarov commented Oct 20, 2020 via email

@nikitaeverywhere
Copy link
Member

just issue a new release on the releases

Thanks for hints! Is it only the owner can create new releases? Or anyone can do it?

@evshvarov
Copy link
Member

evshvarov commented Oct 20, 2020 via email

@nikitaeverywhere
Copy link
Member

nikitaeverywhere commented Oct 21, 2020

Thanks! One more question,

Should the new version be 2020.2 or 1.21.4, as per module.xml?

image

And maybe some additional questions, just out of my curiosity:

  • This PR is just a version bump, what's the point of it? Is there any latest feature code missing from what's on Open Exchange?
  • What happens if I press "Create" on the screenshot above? Will it somehow magically pick the code from this repo?

@evshvarov
Copy link
Member

evshvarov commented Oct 21, 2020 via email

@nikitaeverywhere
Copy link
Member

nikitaeverywhere commented Oct 21, 2020

Error during release save: ERROR #5001: Version number should be greater or equal previous

True. What should we do? @SergeyMi37 what was the intent of this release?

UPD: synced offline. The intent is to have a new version in the package manager, which I guess gets deployed from OEX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants