Don't attempt to open the SMP in a Simple Browser for IRIS 2024.1+

[isc-bsaviano]

This PR fixes #224

[gjsjohnmurray]

Doing that seems unfair on pre 2024.1 sites that have already got this working.

[isc-bsaviano]

I understand that some people might find this useful but I don't think that opening in an external browser is that much worse of a user experience. It's a shame that we didn't have advance notice of this change. I think that adding an IRIS version context key just to hide the button is too much work. I guess I can add another check to the Simple Browser-specific path but I don't like keeping features that only work on old versions. This is a modern/cutting edge tool; it seems wrong to me for it to have features that you have to be out of date to use.

[gjsjohnmurray]

I agree that retrofitting version info into the contextValue of the TreeItems is more work than can be justified here, though there may be future cases where what we show on a tree node needs to take account of the server version.

However I'm unhappy with backward-incompatible changes, and resist us releasing a new version of Server Manager in which a feature that was being used successfully on pre-2024.1 servers suddenly vanishes in the interests of not confusing 2024.1+ users by offering something that a back-incompatible server-side change has rendered non-operational.

Please enhance this code to do the version check and advise the 2024.1+ user that the button they pressed is unable to work with their server level.

intersystems-servermanager/src/api/getPortalUriWithToken.ts

Lines 50 to 74 in 0fe86bf

	if (target === BrowserTarget.SIMPLE && !simpleBrowserCompatible.has(name)) {
	// Check that the portal webapps have all been altered so they don't require session cookie support, which Simple Browser cannot provide
	const response = await makeRESTRequest(
	"POST",
	spec,
	{ apiVersion: 1, namespace: "%SYS", path: "/action/query" },
	{ query: "SELECT Name FROM Security.Applications WHERE {fn CONCAT(Name, '/')} %STARTSWITH '/csp/sys/' AND UseCookies = 2" },
	);
	if (response) {
	const appsRequiringCookie = (response.data?.result?.content as any[]).map((row) => {
	return row.Name as string;
	});
	if (appsRequiringCookie.length > 0) {
	await vscode.window.showWarningMessage(`Portal web apps cannot be used in the Simple Browser tab if their 'UseCookies' property is set to 'Always' (the default). To resolve this, use Portal's security section to change it to 'Autodetect' in these apps: ${appsRequiringCookie.join(", ")}`, { modal: true });
	return;
	}
	else {
	simpleBrowserCompatible.set(name, true);
	}
	}
	else {
	vscode.window.showWarningMessage(`Unable to check the Portal web apps for compatibility with Simple Browser.`);
	simpleBrowserCompatible.set(name, true);
	}
	}

[isc-bsaviano]

I'll make that change for now but when IRIS versions 2024.1+ get more prevalent we will have to remove this button.