Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-level server setting in objectscript.conn should not trump a workspace-level docker-compose setting #898

Closed
gjsjohnmurray opened this issue Mar 14, 2022 · 0 comments · Fixed by #899
Assignees

Comments

@gjsjohnmurray
Copy link
Contributor

To reproduce the issue, have a workspace-level objectscript.conn setting whose docker-compose points to a container:

    "objectscript.conn" :{
      "ns": "USER",
      "username": "SuperUser",
      "password": "SYS",
      "docker-compose": {
        "service": "iris",
        "internalPort": 52773
      },
      "active": true
    }

Confirm that the connection is active.

In the user-level settings add an objectscript.conn that points to a server defined in intersystems.servers:

	"objectscript.conn": {
		"active": true,
		"server": "iris201",
		"ns": "USER"
	},

When you save this, the extension incorrectly tries to connect to the named server in preference to the target container specified in the workspace-level docker-compose setting object.

I will provide a PR.

@gjsjohnmurray gjsjohnmurray self-assigned this Mar 14, 2022
gjsjohnmurray added a commit to gjsjohnmurray/vscode-objectscript that referenced this issue Mar 14, 2022
gjsjohnmurray added a commit that referenced this issue Mar 16, 2022
Give `docker-compose` setting priority over `server` one (fix #898)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant