New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support importing/exporting XML files #1171
Support importing/exporting XML files #1171
Conversation
@gjsjohnmurray @daimor This can be tested with the latest 2023.2 developer preview kit. |
@daimor @gjsjohnmurray Can you please test this when you have some time? I would like to get this and a few other changes merged so we can do a 2.10.0 release soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a little bit of testing made a couple of comments. I also noticed that the Import command pre-populates the "File name" field of the Windows File Open dialog with the string "de-workspace", as though it's grabbing the last 12 characters of the XYZ.code-workspace file I'd saved my ISFS workspace into.
Co-authored-by: John Murray <johnm@georgejames.com>
The grabbing of the last 12 characters might be a VS Code bug, but I use the workspace file's URI as the default for the file picker because otherwise it will show be a virtual file picker for your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running this VSIX build in VS Code debug I was able to solve weird the Import dialog field prepopulation by dropping the filename from the path of the defaultUri. I have proposed a change.
This PR fixes #1158
See the docs for how to use the new commands.