Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support importing/exporting XML files #1171

Merged

Conversation

isc-bsaviano
Copy link
Contributor

@isc-bsaviano isc-bsaviano commented Jun 21, 2023

This PR fixes #1158

See the docs for how to use the new commands.

@isc-bsaviano
Copy link
Contributor Author

@gjsjohnmurray @daimor This can be tested with the latest 2023.2 developer preview kit.

@isc-bsaviano
Copy link
Contributor Author

@daimor @gjsjohnmurray Can you please test this when you have some time? I would like to get this and a few other changes merged so we can do a 2.10.0 release soon.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a little bit of testing made a couple of comments. I also noticed that the Import command pre-populates the "File name" field of the Windows File Open dialog with the string "de-workspace", as though it's grabbing the last 12 characters of the XYZ.code-workspace file I'd saved my ISFS workspace into.

docs/Studio.md Outdated Show resolved Hide resolved
src/utils/documentPicker.ts Outdated Show resolved Hide resolved
Co-authored-by: John Murray <johnm@georgejames.com>
@isc-bsaviano
Copy link
Contributor Author

I've done a little bit of testing made a couple of comments. I also noticed that the Import command pre-populates the "File name" field of the Windows File Open dialog with the string "de-workspace", as though it's grabbing the last 12 characters of the XYZ.code-workspace file I'd saved my ISFS workspace into.

The grabbing of the last 12 characters might be a VS Code bug, but I use the workspace file's URI as the default for the file picker because otherwise it will show be a virtual file picker for your isfs workspace folder. I want to ensure that it always opens a file picker using the local file system.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running this VSIX build in VS Code debug I was able to solve weird the Import dialog field prepopulation by dropping the filename from the path of the defaultUri. I have proposed a change.

src/commands/compile.ts Show resolved Hide resolved
@isc-bsaviano isc-bsaviano merged commit 9e32935 into intersystems-community:master Jul 20, 2023
7 checks passed
@isc-bsaviano isc-bsaviano deleted the server-side-import branch July 20, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revisit support export/import xml
2 participants