Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve language configuration #1311

Merged
merged 3 commits into from Feb 9, 2024
Merged

Improve language configuration #1311

merged 3 commits into from Feb 9, 2024

Conversation

isc-bsaviano
Copy link
Contributor

isc-rsingh
isc-rsingh previously approved these changes Feb 8, 2024
View reviewed changes
gjsjohnmurray
gjsjohnmurray requested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and commented, but not yet tested.

src/languageConfiguration.ts Show resolved Hide resolved
src/languageConfiguration.ts Show resolved Hide resolved
src/providers/FileDecorationProvider.ts Outdated Show resolved Hide resolved
src/providers/FileDecorationProvider.ts Outdated Show resolved Hide resolved
src/commands/studioMigration.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@isc-bsaviano @gjsjohnmurray
Apply suggestions from code review
77c3496 
Co-authored-by: John Murray <johnm@georgejames.com>
@isc-bsaviano
Copy link
Contributor Author

@gjsjohnmurray Thanks for the through review. I've applied your suggestions.

@isc-bsaviano isc-bsaviano merged commit 792a12e into intersystems-community:master Feb 9, 2024
7 checks passed
@isc-bsaviano isc-bsaviano deleted the comments branch February 9, 2024 13:17
@isc-bsaviano isc-bsaviano mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

@isc-rsingh isc-rsingh isc-rsingh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isc-bsaviano @isc-rsingh @gjsjohnmurray