Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support /terminal being hosted deeper than the web server root level #147

Merged

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #142, allowing WebTerminal to work on sites that configure a single web server to host apps for multiple InterSystems servers.

It also updates gulp to version 4 so it works with modern Node versions.

@nikitaeverywhere
Copy link
Member

Hello John! Thanks so much for your work. I'll have a chance to review it over this weekend – will let you know.

Let me know if that's OK

@gjsjohnmurray
Copy link
Contributor Author

I'll have a chance to review it over this weekend – will let you know.

That'll be fine.

@ZitRos FYI I'm also thinking of doing another PR so my VS Code extension can work without the user having to edit the WebTerminal.Router class.

@nikitaeverywhere
Copy link
Member

@ZitRos FYI I'm also thinking of doing another PR so my VS Code extension can work without the user having to edit the WebTerminal.Router class.

I'm supportive. At the time when development started, we didn't have VisualStudio code yet which I love (i.e. in general, a pipeline to work with external editors)

@nikitaeverywhere nikitaeverywhere merged commit c092d3b into intersystems-community:master Jul 2, 2022
@nikitaeverywhere
Copy link
Member

@gjsjohnmurray thanks a ton for the PR. I currently don't have an ability to validate the release, please do it yourself (try to install the old version and update from it through the UI as well).

@nikitaeverywhere
Copy link
Member

The code looks good!

@gjsjohnmurray gjsjohnmurray deleted the fix-142 branch July 2, 2022 14:51
@gjsjohnmurray
Copy link
Contributor Author

@ZitRos thanks for merging and releasing this. I confirmed that UI upgrade from 4.9.3 to 4.9.4 worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from /terminal to /terminalsocket assumes that /terminal was at the root of the URL
2 participants