Support enabling IPM instance-wide #485
Draft
+133
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even %SYS, but not using the %ALL namespace because that ends up overriding namespace-specific mappings (gah).
isc-kiyer
requested changes
May 23, 2024
| } | ||
| Set pointer = 0 | ||
| While $ListNext(namespaces,pointer,namespace) { | ||
| Set $Namespace = namespace |
There was a problem hiding this comment.
Nit: Defensive coding to string leading/trailing white space and control characters from namespace name before trying to switch to it
| Set key = "" | ||
| For { | ||
| Set key = $Order(list(key)) | ||
| Quit:key="" |
There was a problem hiding this comment.
Nit: Avoid using post conditionals
| If globally { | ||
| Set namespaces = "" | ||
| Do ..GetListNamespace(.list) | ||
| Kill list("%ALL") |
There was a problem hiding this comment.
Nit: Add a comment as to why removing %ALL so we don't forget the context.
| Set pointer = 0 | ||
| While $ListNext(namespaces,pointer,namespace) { | ||
| Set $Namespace = namespace | ||
| If $$$comClassDefined("%IPM.Storage.Module") && ##class(%IPM.Storage.Module).NameExists($$$IPMModuleName) { |
There was a problem hiding this comment.
Move existence check for IPM in a specific namespace to a utility helper method so we can keep the checks consistent (will also be helpful for some HS utilities to call probably)
| @@ -1150,6 +1156,38 @@ ClassMethod Version(ByRef pCommandInfo) [ Internal ] | |||
| Quit $$$OK | |||
| } | |||
|
|
|||
| ClassMethod AddIPMMappedNamespaces(ByRef list) [ Private ] | |||
There was a problem hiding this comment.
Nit: Document expected format of list
| Set namespace = "" | ||
| For { | ||
| Set namespace = $Order(allNS(namespace)) | ||
| Quit:namespace="" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done via new options in the existing zpm "enable" command that add package mappings.
We looked into using %ALL but ultimately that doesn't work, because namespace-specific mappings aren't allowed to override %ALL mappings (!?).
Fixes #470