Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: code deletion when switching between multiple instances #81

Merged
merged 15 commits into from
Jan 4, 2024
Merged

fix: code deletion when switching between multiple instances #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
498ce50
WIP: try disabling setText()
MrSurana Dec 26, 2023
65f139a
wip: fix package.json
MrSurana Dec 26, 2023
71e4305
wip: added logs to debug
MrSurana Dec 27, 2023
1f3ce29
changed package version
MrSurana Dec 27, 2023
fd5a5d7
revert setText change
MrSurana Dec 27, 2023
31a9d1e
fixed console logs to print pending
MrSurana Dec 27, 2023
9d481f5
added questionId to debug
MrSurana Dec 27, 2023
d1e5ade
fix build error
MrSurana Dec 27, 2023
223878c
added console.trace in sendOperation
MrSurana Dec 27, 2023
95fd2b9
log setText data to console
MrSurana Dec 27, 2023
73ba309
fix: misplaced _zombie assignment
MrSurana Dec 27, 2023
c2a20bf
removed all debugging code
MrSurana Dec 28, 2023
e74199c
updated package version
MrSurana Dec 28, 2023
145b657
updated package version to comply with semver script
MrSurana Dec 28, 2023
773fda0
fix: update package version
Harshita-Kanal Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@hackerrank/firepad",
"description": "Collaborative text editing powered by Firebase",
"version": "0.8.4-beta",
"version": "0.8.5",
"author": {
"email": "bprogyan@gmail.com",
"name": "Progyan Bhattacharya",
Expand Down
3 changes: 2 additions & 1 deletion src/firebase-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ export class FirebaseAdapter implements IDatabaseAdapter {
}

dispose(): void {
this._zombie = true;
MrSurana marked this conversation as resolved.
Show resolved Hide resolved

if (!this._ready) {
this.on(FirebaseAdapterEvent.Ready, () => {
this.dispose();
Expand All @@ -197,7 +199,6 @@ export class FirebaseAdapter implements IDatabaseAdapter {
this._databaseRef = null;
this._userRef = null;
this._document = null;
this._zombie = true;
}

getDocument(): ITextOperation | null {
Expand Down
Loading