Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Directus module for Nuxt 3.4 runtime config changes #127

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

scherii
Copy link
Contributor

@scherii scherii commented Apr 14, 2023

Adapted the Directus Nuxt module to work with Nuxt 3.4's updated runtime configuration handling, following the deprecation of old (pre-rc) runtimeConfig.

For more information, check out nuxt/nuxt#20082.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

This PR adapts the Directus Nuxt module to work with Nuxt 3.4's updated runtime configuration handling. This is necessary due to the deprecation of old (pre-rc) runtimeConfig. The changes ensure that the module continues to work as expected with the latest version of Nuxt.

For more information, please see nuxt/nuxt#20082.

Closes #126.

Adapted the Directus Nuxt module to work with Nuxt 3.4's updated runtime configuration handling, following the deprecation of old (pre-rc) runtimeConfig.

For more information, check out nuxt/nuxt#20082.
Located another instance requiring adaptation to Nuxt 3.4 runtime configuration handling, not covered in the previous commit.
@scherii scherii marked this pull request as ready for review April 14, 2023 13:50
@scherii
Copy link
Contributor Author

scherii commented Apr 14, 2023

@Intevel Hi Conner! I've tested the changes with Nuxt 3 successfully, but haven't checked compatibility with Nuxt 2 / Bridge. Thanks for your time reviewing this PR. 🙂

@Intevel
Copy link
Owner

Intevel commented Apr 15, 2023

LGTM, good work. I will release it with the newest version in a few days❤️

@Intevel Intevel merged commit 75b1289 into Intevel:main Apr 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config['directus'] to config.public['directus']
2 participants