Update intezer_analyze_gh_community.py #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidt99
reviewed
Sep 6, 2020
| sys.path.append('C:\\Python27\\lib\\site-packages') | ||
| else: | ||
| print('Whelp, something went wrong.') |
There was a problem hiding this comment.
This is not solving the os.name java issue as far as I understand, correct?
|
The print statement in else? No - that’s just embellishment on my part; it’s me being a bit glib with respect to error handling in the event that a prior condition is not met. With respect to os.name returning java, that’s not an error. Ghidra comes packaged with the jython interpreter, so any python Ghidra scripts are interpreted using Jython. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help resolve some of the
site-packagespathing issues that some users are encountering on Debian, macOS, and Windows.If memory serves, there's a difference between the way Debian (and its derivative distros) treat
site-packages(i.e. the path isdist-packages, as reflected in the script, butsite-packageson other flavors), which is why there's a test "Posix" and "Linux" in the initialifstatement. Perhaps someone smarter than I can come up with a way to test for Linux distro.