Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permission_classes type on get_schema_view #6

Closed
palfrey opened this issue Aug 19, 2020 · 1 comment · Fixed by #7
Closed

permission_classes type on get_schema_view #6

palfrey opened this issue Aug 19, 2020 · 1 comment · Fixed by #7

Comments

@palfrey
Copy link

palfrey commented Aug 19, 2020

I've got some code that sets the permission_classes arg for get_schema_view to (permissions.AllowAny,), and I get the error
error: Argument "permission_classes" to "get_schema_view" has incompatible type "Tuple[Type[AllowAny]]"; expected "Optional[Tuple[str]]"

Admittedly, in my particular use case it turns out I can delete the arg as it's the defaults, but if I wanted a non-default I'd get issues with mypy.
@intgr intgr mentioned this issue Aug 19, 2020
Merged
@intgr intgr closed this as completed in #7 Aug 19, 2020
intgr added a commit that referenced this issue Aug 19, 2020
@intgr
Fix get_schema_view() arguments authentication_classes, permission_cl…
6f1f324 
…asses (#6)

Also removed redundant & wrong attributes declared in _SchemaView class, they are now inherited from APIView.
@intgr
Copy link
Owner

intgr commented Aug 19, 2020

Thanks, released 0.1.2 with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix get_schema_view() arguments authentication_classes, permission_classes intgr/drf-yasg-stubs
2 participants
@palfrey @intgr