Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: location query type signature compatibility #38

Conversation

BobbieGoede
Copy link
Member

Description

Aims to resolve nuxt-modules/i18n#2152, I still need to test this locally.

Linked Issues

nuxt-modules/i18n#2152

Additional context

@BobbieGoede
Copy link
Member Author

The e2e action ran for 6 hours 🤯, seems to be fixed after updating playwright and vite-test-utils as seen by the actions on the PR on my fork here BobbieGoede#2.

@kazupon
Copy link
Member

kazupon commented Sep 16, 2023

Oh, my God. We might be careful not to have our github actions blocked 😅

@kazupon kazupon marked this pull request as ready for review September 16, 2023 16:29
@kazupon kazupon merged commit ad7f3ab into intlify:main Sep 17, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localePath/localRoute incompatible with index signature
2 participants