Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vue-class-components support via loader option #75

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Add vue-class-components support via loader option #75

merged 2 commits into from
Dec 16, 2021

Conversation

SniperJoe
Copy link
Contributor

Issue: #74

kazupon
kazupon requested changes Dec 14, 2021
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Welcome! :)

I have a request.
Could you add the unit test, please? 🙏
We need the code to verify that it is working correctly.

@kazupon kazupon added Package: bundle-utils Type: Improvement Includes backwards-compatible fixes labels Dec 14, 2021
@SniperJoe
Copy link
Contributor Author

@kazupon done.
I'm not familiar with snapshot testing, but I hope everything is fine :)

@kazupon
Copy link
Member

kazupon commented Dec 16, 2021

@SniperJoe
Thank you very much!

@kazupon kazupon merged commit a881937 into intlify:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
Package: bundle-utils Package: vue-i18n-loader Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SniperJoe @kazupon