Apply rule against root-level strings (#9)

* Apply rule against root-level strings * Create moody-adults-camp.md * Use `trim` instead of both `trimStart` an `trimEnd` Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com> * Use `trim` instead of both `trimStart` an `trimEnd` Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com> --------- Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
intlify · Jan 16, 2024 · a311f0e · a311f0e
1 parent 916837b
commit a311f0e
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 5 deletions.
diff --git a/.changeset/moody-adults-camp.md b/.changeset/moody-adults-camp.md
@@ -0,0 +1,5 @@
+---
+"@intlify/eslint-plugin-svelte": minor
+---
+
+Apply rule against root-level strings
diff --git a/lib/rules/no-raw-text.ts b/lib/rules/no-raw-text.ts
@@ -113,7 +113,7 @@ function checkSvelteLiteralOrText(
   const loc = literal.loc!
   context.report({
     loc,
-    message: `raw text '${literal.value}' is used`
+    message: `raw text '${literal.value.trim()}' is used`
   })
 }
 
@@ -134,7 +134,7 @@ function checkLiteral(
   const loc = literal.loc!
   context.report({
     loc,
-    message: `raw text '${value}' is used`
+    message: `raw text '${String(value).trim()}' is used`
   })
 }
 /**
@@ -157,6 +157,7 @@ function parseTargetAttrs(
 
 function create(context: RuleContext): RuleListener {
   const sourceCode = context.getSourceCode()
+
   const config: Config = {
     attributes: [],
     ignorePattern: /^$/,
@@ -180,9 +181,12 @@ function create(context: RuleContext): RuleListener {
   function isIgnore(node: SvAST.SvelteMustacheTag | SvAST.SvelteText) {
     const element = getElement(node)
 
-    return (
-      !element ||
-      config.ignoreNodes.includes(sourceCode.text.slice(...element.name.range!))
+    if (!element) {
+      return false
+    }
+
+    return config.ignoreNodes.includes(
+      sourceCode.text.slice(...element.name.range!)
     )
   }
   function getElement(node: SvAST.SvelteMustacheTag | SvAST.SvelteText) {

diff --git a/tests/lib/rules/no-raw-text.ts b/tests/lib/rules/no-raw-text.ts
@@ -47,6 +47,12 @@ tester.run('no-raw-text', rule as never, {
       <p>world</p>
       `,
       options: [{ ignoreText: ['hello', 'world'] }]
+    },
+    {
+      code: `
+        { $_('root level translation') }
+      `,
+      options: []
     }
   ],
 
@@ -224,6 +230,19 @@ tester.run('no-raw-text', rule as never, {
           column: 23
         }
       ]
+    },
+    {
+      code: `
+        <script>
+        </script>
+        
+        text at the root of the template
+      `,
+      errors: [
+        {
+          message: "raw text 'text at the root of the template' is used"
+        }
+      ]
     }
   ]
 })