Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no-missing-keys rule reports false positive with trailing dot #394

Merged
merged 2 commits into from
Jul 22, 2023
Merged

fix: no-missing-keys rule reports false positive with trailing dot #394

merged 2 commits into from
Jul 22, 2023

Commits on Jul 22, 2023

  1. fix: no-missing-keys rule reports false positive with trailing dot 

    For a translation key like $t('missing.') the parse function from core utilities returns undefined.

Previously this was turned into an empty array which caused all of those paths to be false positives.

If the given key can't be parsed as "path" properly, the correct handling is to treat it as a single item path with the provided string as the only item.

This also revealed another faulty test, where keypath="'hello'" was passing even though it should not.
    @wolfgangwalther @ota-meshi
    wolfgangwalther authored and ota-meshi committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    87797c9 View commit details
    Browse the repository at this point in the history

  2. Create forty-tools-dream.md

    @ota-meshi
    ota-meshi committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    f578426 View commit details
    Browse the repository at this point in the history