Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to apply update when resource file is updated. #87

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

ota-meshi
Copy link
Member

This PR changes the cached resource to be refreshed by the resource modification.

closes #9

@ota-meshi ota-meshi added the Type: Improvement Includes backwards-compatible fixes label Jul 28, 2020
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ota-meshi ota-meshi merged commit 8c912c1 into master Aug 5, 2020
@ota-meshi ota-meshi deleted the hot-reload branch August 5, 2020 02:19
@tmcdos
Copy link

tmcdos commented Aug 5, 2020

The code uses polling instead of real file watching. Would you be so kind to explain how a change in the locale file contents will trigger ESLint reevaluation ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No hot-reloading support
3 participants