fix: useRouteBaseName composable does not return function
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
changed the title
useRouteBaseName composable does not return function
kazupon
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is included from #32
Thank @BobbieGoede your contribution
Linked Issues
Linked issue said:
This PR is breaking changes.
Nuxt i18n module must be changed as well.
useRouteBaseNamecomposable to return a function that can be used to get the route base name, not return directly get the route base name.The reason is that you need a context environment (e.g.
setup) in which you can run Vue Composition API such as useRoute internally.Additional context