fix: route resolve loses query parameters #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BobbieGoede - This fix will be a live-saver. I hope it gets merged asap. I've been stuck on this bug for quite a while 😔 |
|
@kazupon Hello, could you please review and merge this PR? This bug has been bothering me for a long time, and it would be great if it could be fixed. Thanks for your help! |
|
Ah, Sorry |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
resolvelosing query parameters when passing a route object, tests have also been added to test this behavior. This PR changesresolveto merge the resolved route into the passed route.Linked Issues
nuxt-modules/i18n#2020
nuxt-modules/i18n#1967
Additional context