nuxt3 integration #1044
Merged
nuxt3 integration #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
added
Type: Example
atinux
reviewed
Jul 5, 2022
atinux
reviewed
Jul 5, 2022
atinux
reviewed
Jul 5, 2022
atinux
reviewed
Jul 5, 2022
atinux
reviewed
Jul 5, 2022
atinux
reviewed
Jul 5, 2022
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
xfq
reviewed
Jul 6, 2022
xfq
reviewed
Jul 6, 2022
xfq
reviewed
Jul 6, 2022
xfq
reviewed
Jul 6, 2022
xfq
reviewed
Jul 6, 2022
xfq
reviewed
Jul 6, 2022
docs/guide/integrations/nuxt3.md
Outdated
| + <option value="ja">ja</option> | ||
| + </select> | ||
| + </form> | ||
| + </div> |
There was a problem hiding this comment.
</div> is already in app.vue, not a new addition, so no plus sign is needed at the beginning of the line.
xfq
reviewed
Jul 6, 2022
xfq
reviewed
Jul 6, 2022
docs/guide/integrations/nuxt3.md
Outdated
| legacy: false, | ||
| globalInjection: true, | ||
| locale: 'en', | ||
| - messages: { |
There was a problem hiding this comment.
It doesn't seem like there should be a minus sign in front of messages, since en, fr, ja are all in the messages option.
xfq
reviewed
Jul 6, 2022
Co-authored-by: Fuqiao Xue <xfq@w3.org>
Co-authored-by: Fuqiao Xue <xfq@w3.org>
Co-authored-by: Fuqiao Xue <xfq@w3.org>
Co-authored-by: Fuqiao Xue <xfq@w3.org>
Co-authored-by: Fuqiao Xue <xfq@w3.org>
Co-authored-by: Fuqiao Xue <xfq@w3.org>
Co-authored-by: Fuqiao Xue <xfq@w3.org>
|
@xfq |
kazupon
commented
Jul 7, 2022
| + alias: { | ||
| + 'vue-i18n': 'vue-i18n/dist/vue-i18n.runtime.esm-bundler.js' | ||
| + } | ||
| + }, |
There was a problem hiding this comment.
@atinux
vite.resolve.alias isn't needed no longer, so It's set in @intlify/unplugin-vue-i18n.
https://github.com/intlify/bundle-tools/releases/tag/unplugin-vue-i18n%400.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.