Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test that ensures that downstream clients of Hashie::Mash don't break #218

Closed
dblock opened this issue Aug 27, 2014 · 0 comments · Fixed by #219
Closed

Add a test that ensures that downstream clients of Hashie::Mash don't break #218

dblock opened this issue Aug 27, 2014 · 0 comments · Fixed by #219

Comments

@dblock
Copy link
Member

dblock commented Aug 27, 2014

We reverted a change in #217 that broke Grape (#215) and Omniauth (#216). Add a test that very explicitly ensures that doesn't happen in the future (needs a comment in the lines of "this assumption cannot change because ...).

Maybe one of @gregory @maciejmajewski @mbleigh @kenips @michaelherold can help ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant