Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on encoding class #253

Merged

Conversation

Motoshi-Nishihira
Copy link
Contributor

fix broken build about #251

Encoding class are implemented as of ruby 1.9.

In ruby 1.8, string don't have the encoding information.
So no error is raised by joining different encoding strings.

irb(main):001:0> ["∞".kconv(Kconv::EUC, Kconv::UTF8), "∞"].join
=> "\241\347\342\210\236"

As of 1.9

irb(main):001:0> ["∞".kconv(Kconv::EUC, Kconv::UTF8), "∞"].join
Encoding::CompatibilityError: incompatible character encodings: EUC-JP and UTF-8

@sferik
Copy link
Contributor

sferik commented May 16, 2016

It looks like some of our code quality metrics are now broken. Would you mind refactoring this pull request to fix those?

@coveralls
Copy link

coveralls commented May 21, 2016

Coverage Status

Coverage increased (+0.07%) to 96.629% when pulling ee7d5d5 on Motoshi-Nishihira:remove-dependency-on-encoding-class into 7691a2c on intridea:master.

@sferik sferik merged commit 41de091 into oauth-xx:master Jul 1, 2016
@sferik
Copy link
Contributor

sferik commented Jul 1, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants