Update net-ldap gem to avoid errors with some LDAP Servers #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Please accept this PR. |
|
+1 I also have trouble (german umlauts) with net-ldap in version 0.2.x. Please upgrade the specfile. |
pyu10055
pushed a commit
that referenced
this pull request
Dec 11, 2013
Update net-ldap gem to avoid errors with some LDAP Servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to use omniauth-ldap with a 389-ds/IPA LDAP Server that uses protocol v3. LDAP searching was not working, returning with a Protocol Error. I found this thread which explains a very similar problem: http://comments.gmane.org/gmane.comp.version-control.gitlab/406
I found that only by updating the net-ldap gem this issue gets fixed, so I'm providing PR with the gem version updated.
I'm not adding the updated Gemfile.lock since that should not be in the repo.
The specs ran successfully!