Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example callback route to be POST, not GET (in Readme). #712

Closed
wants to merge 1 commit into from

Conversation

arnab
Copy link

@arnab arnab commented Dec 10, 2013

  • tiny change in README to update the route from get to post.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5c1dc01 on arnab:fix-route-example-in-readme into 7c97b20 on intridea:master.

@mbleigh
Copy link
Contributor

mbleigh commented Dec 10, 2013

The endpoint may be GET or POST based on the provider, and I'd wager that it's more often GET than POST (Twitter, Facebook, GitHub, LinkedIn, Google are all GET).

I'd be open to a commit that clarifies that this varies based on the strategy.

@sferik sferik closed this Jan 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants