Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoRehab: Stream local music audio #230

Closed
SBriere opened this issue Sep 14, 2023 · 0 comments
Closed

VideoRehab: Stream local music audio #230

SBriere opened this issue Sep 14, 2023 · 0 comments
Assignees
@SBriere
Labels
enhancement New feature or request

Comments

@SBriere
Copy link
Member

SBriere commented Sep 14, 2023

Describe the solution you'd like
Allow to stream local audio from any local source, with a sufficient audio quality for music.

Screen sharing capabilities could be exploited to stream only audio and explore WebRTC settings to improve audio quality.
@SBriere SBriere added the enhancement New feature or request label Sep 14, 2023
@SBriere SBriere self-assigned this Sep 14, 2023
SBriere added a commit that referenced this issue Sep 14, 2023
@SBriere
Refs #230. Added first implementation music streaming in VideoRehab.
ff691b7
SBriere added a commit that referenced this issue Sep 14, 2023
@SBriere
Refs #230. Fixed audio sharing not working and not stopping. Added co…
1110eb6 
…nstraints to try to improve audio quality
SBriere added a commit that referenced this issue Sep 14, 2023
@SBriere
Refs #230. Fixed screen sharing not showing screen if not audio only.
eadbddb
SBriere added a commit that referenced this issue Sep 14, 2023
@SBriere
Refs #230. Fix for not being able to stop music sharing.
44d130c
SBriere added a commit that referenced this issue Sep 15, 2023
@SBriere
Refs #230. Fixed screen sharing not working anymore. Updated music pl…
d178fe5 
…aying icon.
SBriere added a commit that referenced this issue Sep 19, 2023
@SBriere
Refs #230. Added SDP filter to try to improve music quality.
430c8fc
SBriere added a commit that referenced this issue Sep 21, 2023
@SBriere
Refs #230. Adjusted SDP filter for higher quality audio.
913a54d
SBriere added a commit that referenced this issue Sep 26, 2023
@SBriere
Refs #230. Adjusted video parameters when streaming music.
fb4d92c
SBriere added a commit that referenced this issue Sep 26, 2023
@SBriere
Refs #230. Tentative fix to mute speakers when remote streams count > 4.
2d12479
SBriere added a commit that referenced this issue Oct 4, 2023
@SBriere
Refs #230. Reworked layout manager to prevent display of "blank" musi…
b33ea06 
…c video
SBriere added a commit that referenced this issue Oct 4, 2023
@SBriere
Refs #230. Tentative fix for unmute speaker not working on music share.
4dbaaa7
SBriere added a commit that referenced this issue Oct 5, 2023
@SBriere
Refs #230. Added icon and moved video area on participant layout when…
9141d4d 
… user is sharing music.
SBriere added a commit that referenced this issue Oct 12, 2023
@SBriere
Refs #230. Fixed issue on music not playing when speaker is initially…
fc7fe31 
… muted on Chrome.
@SBriere SBriere closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SBriere SBriere

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SBriere