Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize slider height and track colors #220

Merged
merged 1 commit into from Jan 10, 2020

Conversation

bcarreon
Copy link
Contributor

@bcarreon bcarreon commented Jan 8, 2020

Before you make a Pull Request, read the important guidelines:

Issue Link 馃敆

  • Is this a bug fix or a feature?
  • Does it break any existing functionality?

Goals of this PR 馃帀

  • Why is the change important?
  • What does this fix?
  • How far has it been tested?

How Has This Been Tested 馃攳

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

  • User Interface Testing
  • Application Testing

Test Configuration 馃懢

  • Xcode version:
  • Device/Simulator
  • iOS version || MacOSX version

Things to check on 馃幆

  • My Pull Request code follows the coding standards and styles of the project
  • I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

@croossin
Copy link
Contributor

LGTM 馃憤

@croossin croossin merged commit b225289 into intuit:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants