Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for Typescript support on Storybook, build and Jest #40

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

josediego
Copy link
Contributor

What Changed

  • Create new tsconfig.json file with the basic configuration to transpile tscode.
  • Create a typescript.tsx file under FeatureFlag directory to parse the code from js to typescript.
  • Update the current imported file on FeatureFlag.stories.jsx from index.js to typescript.tsx in order to test if storybook configuration is working fine.
  • Add missing dependencies to package.json related to Typescript, tsjest and storybook typescript plugins.

Why

Refactor for TypeScript: FeatureFlag Component #35

* Create new tsconfig.json file with the basic configuration to transpile tscode.
* Create a typescript.tsx file under FeatureFlag directory to parse the code from js to typescript.
* Update the current imported file on FeatureFlag.stories.jsx from index.js to typescript.tsx in order to test if storybook configuration is working fine.
* Add missing dependencies to package.json related to Typescript, tsjest and storybook typescript plugins.
Copy link
Contributor

@poorpaddy poorpaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Good catches on the const's.

@poorpaddy poorpaddy merged commit dd754c3 into intuit:master Oct 4, 2019
@josediego
Copy link
Contributor Author

At your service! Let me know if you need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants