schema updates #132
Merged
schema updates #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema updates to add County field
| @@ -310,7 +310,7 @@ protected String getBaseUrl(String url) { | |||
|
|
|||
| if(context.getMinorVersion() == null) | |||
| { | |||
| context.setMinorVersion("47"); | |||
| context.setMinorVersion("50"); | |||
There was a problem hiding this comment.
Let's not default to 50 as it is an unreleased version and in such cases it will default to 1 instead which we don't want.
diana-derose
requested changes
May 19, 2020
There was a problem hiding this comment.
@shweta-intuitdev - Is the intention to just update the schema or generate the data jar as well?
Could you also fix travis errors.
diana-derose
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema updates to add County field