Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SSO Functionality #160

Merged
merged 12 commits into from
Oct 13, 2021
Merged

Support SSO Functionality #160

merged 12 commits into from
Oct 13, 2021

Conversation

shawn-h-park
Copy link
Collaborator

@shawn-h-park shawn-h-park commented Oct 7, 2021 •
edited

SSO: - Ability to support OIDC-based SSO

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

kevin-mcgoldrick
kevin-mcgoldrick approved these changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawn-h-park
Support simultaneous standard & SSO login (#163)
c9953f2 
* Support simultaneous standard & sso login

* (1) Switch SSO button order to be on top + (2) Render upon config present
@shawn-h-park shawn-h-park merged commit ff8cdb6 into master Oct 13, 2021
@kevin-mcgoldrick kevin-mcgoldrick deleted the SSO-Support branch December 9, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-mcgoldrick kevin-mcgoldrick kevin-mcgoldrick approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shawn-h-park @kevin-mcgoldrick