Adding units tests for agent_common module #162
Conversation
| String value2 = null; | ||
| keyValueRequest.setKey(key1, value1); | ||
| keyValueRequest.setKey(key2, value2); | ||
| assertEquals("=value1&key2=", keyValueRequest.getBody()); |
There was a problem hiding this comment.
@kevin-mcgoldrick Is this the expected output from getBody when either key or value is null? Or shall I change https://github.com/intuit/Tank/blob/master/agent/agent_common/src/main/java/com/intuit/tank/http/keyvalue/KeyValueRequest.java#L69 to ignore the key-value if either of them is null?
| String value2 = null; | ||
| keyValueRequest.setKey(key1, value1); | ||
| keyValueRequest.setKey(key2, value2); | ||
| assertEquals("=value1&key2=", keyValueRequest.getBody()); |
There was a problem hiding this comment.
@kevin-mcgoldrick Is this the expected output from getBody when either key or value is null? Or shall I change https://github.com/intuit/Tank/blob/master/agent/agent_common/src/main/java/com/intuit/tank/http/keyvalue/KeyValueRequest.java#L69 and https://github.com/intuit/Tank/blob/master/agent/agent_common/src/main/java/com/intuit/tank/http/keyvalue/KeyValueRequest.java#L70 to ignore the key-value if either of them is null?
title: - <Adding tests for issue #88 >
Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **