Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE-19855 Add job creator to job description #166

Merged
merged 2 commits into from
Oct 20, 2021
Merged

SRE-19855 Add job creator to job description #166

merged 2 commits into from
Oct 20, 2021

Conversation

bryaan
Copy link
Contributor

@bryaan bryaan commented Oct 20, 2021 •
edited

Add job creator to job description.

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@kevin-mcgoldrick
Copy link
Collaborator

No, this will get the project creator which is not the person to started the job.
You'll need to pull the principal from the security context in the JobMaker.java file.

kevin-mcgoldrick
kevin-mcgoldrick approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryaan bryaan merged commit de12e5b into master Oct 20, 2021
@bryaan bryaan deleted the SRE-19855 branch October 20, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-mcgoldrick kevin-mcgoldrick kevin-mcgoldrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bryaan @kevin-mcgoldrick