Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SRE-22163] - Test Plan Bug #194

Merged
merged 4 commits into from
Mar 30, 2022
Merged

[SRE-22163] - Test Plan Bug #194

merged 4 commits into from
Mar 30, 2022

Conversation

bryaan
Copy link
Contributor

@bryaan bryaan commented Mar 24, 2022

Test Plan Bug

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

shawn-h-park
shawn-h-park approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@shawn-h-park shawn-h-park left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Edited: Please refer to comment below

@shawn-h-park shawn-h-park self-requested a review March 24, 2022 18:37
@shawn-h-park shawn-h-park self-requested a review March 24, 2022 18:39
shawn-h-park
shawn-h-park requested changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@shawn-h-park shawn-h-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment above

@kevin-mcgoldrick kevin-mcgoldrick changed the title Sre 22163 - Test Plan Bug [SRE-22163] - Test Plan Bug Mar 29, 2022
@kevin-mcgoldrick kevin-mcgoldrick merged commit dd54aa8 into master Mar 30, 2022
@kevin-mcgoldrick kevin-mcgoldrick deleted the SRE-22163 branch March 30, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-h-park shawn-h-park shawn-h-park requested changes

@kevin-mcgoldrick kevin-mcgoldrick Awaiting requested review from kevin-mcgoldrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryaan @shawn-h-park @kevin-mcgoldrick