Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased code coverage of api package to 80% #229

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Increased code coverage of api package to 80% #229

merged 1 commit into from
Jan 17, 2023

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Jan 17, 2023 •
edited

title: - Increased code coverage of api package to 80%

Screen Shot 2023-01-17 at 9 22 44 AM

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

kevin-mcgoldrick
kevin-mcgoldrick approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@kevin-mcgoldrick kevin-mcgoldrick merged commit cdbb7dd into master Jan 17, 2023
@kevin-mcgoldrick kevin-mcgoldrick deleted the zkofiro/SRE-25872 branch January 17, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-mcgoldrick kevin-mcgoldrick kevin-mcgoldrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zakaria-Kofiro @kevin-mcgoldrick