Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased code coverage of agent/apiharness from 36% to 80% #232

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Feb 3, 2023

title: - Increased code coverage of agent/apiharness from 36% to 80%
Screen Shot 2023-02-03 at 11 07 49 AM

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@shawn-h-park shawn-h-park self-requested a review February 3, 2023 23:23
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shawn-h-park shawn-h-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

formatting changes

fix: updated APITestHarness error

fix: final formatting + removing unused imports

fix: added tests + APITestHarness setup/teardown

fix: adding teardown here as well

fix: last update, passes tests locally
@Zakaria-Kofiro Zakaria-Kofiro merged commit fcadfbb into master Feb 4, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/SRE-25871 branch February 4, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants