Code Coverage Follow up: Updating test variable scope to private #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-h-park
requested changes
Feb 16, 2023
| @@ -6,6 +6,5 @@ public class CommandListenerTest { | |||
| @Test | |||
| public void testCommandListenerTest_1() { | |||
| CommandListener.main(new String[]{}); | |||
| CommandListener.startTest(); | |||
There was a problem hiding this comment.
@Zakaria-Kofiro Not exactly related to your goal of scoping test vars to private, but wondering what testCommandListenerTest_1 is testing for with the absence of any assertions
| @BeforeEach | ||
| public void init() { | ||
| instance = APITestHarness.getInstance(); | ||
| APITestHarness instance = APITestHarness.getInstance(); |
There was a problem hiding this comment.
@Zakaria-Kofiro Since this var instance of APITestHarness is not being used within the test can we remove the variable? Also because it's a private static var within APITestHarness.Java
| @@ -9,8 +9,8 @@ | |||
|
|
|||
| public class OidcSsoConfigTest { | |||
|
|
|||
| HierarchicalConfiguration config = new HierarchicalConfiguration(); | |||
| OidcSsoConfig oidc = null; | |||
| private final HierarchicalConfiguration config = new HierarchicalConfiguration(); | |||
There was a problem hiding this comment.
@Zakaria-Kofiro Not related to this change, but can we remove unused import com.intuit.tank.vm.vmManager.VMInstanceRequest on line 3
fix: removed unneeded var and import, added assert
Zakaria-Kofiro
force-pushed
the
zkofiro/code-cov-scope-fix
branch
from
2db7da8
to
4d05244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: - Test variable scope changed to private across new tests + fixed a test exiting when ran in IDE (code cov unchanged)
Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **