Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new routes for clients and fixed datafile compression issue #236

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Added new routes for clients and fixed datafile compression issue #236

merged 1 commit into from
Apr 5, 2023

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Apr 3, 2023 •
edited

This PR includes the following changes to prepare for merging V2 clients:

  • Created /names endpoint for project, datafile, scripts that returns < id, names> list for each service
  • Added new routes to agent and projects used by V2 client dependencies (agent, tools)
  • Fixed an issue with uploading compressed datafile in QA, now decompresses the file correctly
  • Updated job/agent instance status response to return a status string instead of no content
  • Added new job creation naming options and a default job name if naming parameters are left blank
  • Hid non-user-facing agent routes from Swagger UI (i.e v2/agent/ready, etc)

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

fix: should fix datafile compress issue in QA + adding new routes for…
5230cf7 
… clients

fix: unneeded file

feat: adding new names routes and updating swagger ui routes + err msgs

fix: small doc/import changes + trigger QA build

fix: updating error descriptions + adding missing service call

fix: small doc change
@Zakaria-Kofiro Zakaria-Kofiro merged commit 369701e into master Apr 5, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/datafile-compress-fix branch April 5, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-h-park shawn-h-park shawn-h-park approved these changes

@kevin-mcgoldrick kevin-mcgoldrick Awaiting requested review from kevin-mcgoldrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zakaria-Kofiro @shawn-h-park