Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting XML namespaces from V2 back to V1 #244

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Jun 9, 2023

title: - Reverting XML namespaces from V2 back to V1

Tank tools currently running the V1 API are expecting NAMESPACE_V1 from Tank XML files, while the namespace for several models has been updated to V2. To remediate this issue, it will need to be reverted back to V1 to work with the current V1 tools. It will be kept at V1 since a namespace version update is not needed for continued functionality.

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review June 9, 2023 19:36
@shawn-h-park shawn-h-park self-requested a review June 9, 2023 20:21
@Zakaria-Kofiro Zakaria-Kofiro merged commit 1fd5143 into master Jun 9, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/revert-namespace branch June 9, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants