Temporary logging to debug script group bug #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zakaria-Kofiro
changed the title
added 2 commits
July 11, 2023 13:51
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| <context-param> | |||
| <param-name>javax.faces.PROJECT_STAGE</param-name> | |||
| <param-value>Production</param-value> | |||
| <param-value>Development</param-value> | |||
There was a problem hiding this comment.
@Zakaria-Kofiro Can you explain the reason for this change?
There was a problem hiding this comment.
Oh, this is a change Kevin suggested where setting this from Production to Development enables error messages logs that wouldn't normally appear if set to Production, to help with debugging. Basically enables additional logging.
https://stackoverflow.com/questions/19193912/uses-of-javax-faces-project-stage
shawn-h-park
approved these changes
Jul 11, 2023
Zakaria-Kofiro
pushed a commit
that referenced
this pull request
Jul 14, 2023
This reverts commit 7abc93d.
Zakaria-Kofiro
added a commit
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: Temporary logging to debug script group bug
Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **