Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 apply filter and upload script fix #249

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Jul 6, 2023

title: - V2 apply filter + upload script fix

This PR includes changes to the apply-filters endpoint to also setScriptStepLabels. This allows the endpoint to not only apply filter and filter groups but also update the script step labels after filters are applied as the UI does. The application.yml has also been updated with a max file and request size of 200MB to avoid any max file upload errors.

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro merged commit 6847b9a into master Jul 6, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/v2-filter-fix branch July 6, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants