Tank V2 API: Add script update endpoint to import Tank XML scripts #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-h-park
reviewed
Aug 4, 2023
| @@ -181,6 +181,18 @@ public void testUploadScript() throws IOException { | |||
| verify(scriptService).uploadProxyScript("testName", 0, "gzip", null); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
@Zakaria-Kofiro Can we add one unit test error updating use-case or when a file does not exist?
There was a problem hiding this comment.
Yup, will add.
shawn-h-park
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tank API V2: Add script update endpoint to import Tank XML scripts
/v2/scripts/updateThis endpoint mirrors the functionality of importing Tank XML scripts to update existing scripts. It supports both XML and
.gzipfiles.Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **