Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag Agents at Creation Time #267

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Tag Agents at Creation Time #267

merged 2 commits into from
Sep 13, 2023

Conversation

kevin-mcgoldrick
Copy link
Collaborator

Tag Agents at Creation Time

  • Remved tagInstance method (after creation)
  • Added tagSpecifications to runInstancesRequestTemplate to tag during build time
  • Change DataConverter to static methods
  • Updated DataConverter Tests

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

Zakaria-Kofiro
Zakaria-Kofiro approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevin-mcgoldrick kevin-mcgoldrick merged commit 70bdb3b into master Sep 13, 2023
@kevin-mcgoldrick kevin-mcgoldrick deleted the TagEC2onCreation branch September 13, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zakaria-Kofiro Zakaria-Kofiro Zakaria-Kofiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevin-mcgoldrick @Zakaria-Kofiro