Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller JSON logging and sending Agent TPS and Session Start metrics to Cloudwatch #274

Merged
merged 15 commits into from
Oct 5, 2023

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Oct 5, 2023

Controller JSON logging and sending Agent TPS and Session Start metrics to Cloudwatch

Controller Logging:

  • Enabled JSON logging to track controller workflow in spinning up agents with thread context initialized on job start
  • instanceId assigned to controller EC2 instance to track controller logs for each job
  • Added stopBehavior , termination policy, and useEips fields to controller logs, with stopBehavior and useEips propagated to agent logs
  • Tank V2 API Logging Interceptor implemented to add/clear thread context for V2 API logging (namely agentReady)

Agent Logging:

  • Fixed logs missing JSON fields across some calls (i.e RunConcurrentTestPlans())
  • stopBehavior and useEips fields added to logs

All JSON logs are now consistently using ObjectMessage mapping for the message field.

Cloudwatch Metrics:

  • Now sending Agent TPS and Session Start metrics to CloudWatch

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro merged commit 06c5e47 into master Oct 5, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/controller-agent-logs branch October 26, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants