Thread Buildup Fix - Reduce total active threads to only agent threads

[Zakaria-Kofiro]

Thread Buildup Fix - Reduce total active threads to only agent threads

Currently, when running a job, each agent instance is spinning up numerous additional threads per user thread, resulting in a total of up to 10x-15x times the amount of active threads requested. This resulted in an overhead of unnecessary active threads during job runs, and in some cases, caused agents to crash for certain EC2 instance types when ran long enough:

The root cause of these unnecessary additional threads was found to be due to a call from the LogUtil class to AmazonUtil creating a new HttpClient object each time it was called and subsequently spinning up around 7-8 helper threads in the process for each call for each agent/user thread (see above). The logging util class is used throughout the agent code.

This is fixed by moving the HttpClient object to be a static member of AmazonUtil, so that it is created once and reused for all calls. This greatly improves the performance of jobs by now limiting the total number of threads run to only agent threads:

Please make sure these check boxes are checked before submitting

• ** Squashed Commits **
• ** All Tests Passed ** - mvn clean test -P default

** PR review process **

• Requires one +1 from a reviewer
• Repository owners will merge your PR once it is approved.

[kevin-mcgoldrick]

@Zakaria-Kofiro Can you make it final?