Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunset V1 API Module #279

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Sunset V1 API Module #279

merged 4 commits into from
Nov 7, 2023

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Nov 2, 2023

Sunset V1 API Module

  • Move script models under api module (com/intuit/tank/script/models) to be referenced by V2 API, Script Processor and Tools module
  • Remove the entire V1 API module (rest) along with all remaining script model references

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review November 3, 2023 17:10
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So BIG

@Zakaria-Kofiro Zakaria-Kofiro merged commit 1f0b64f into master Nov 7, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/remove-v1-module branch February 2, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants