Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonlinear Workload - Simplify Code + QOL changes #291

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Dec 7, 2023

Nonlinear Workload - Simplify Code + QOL changes

Small update to nonlinear workload including:

  • simplifying and cleaning up the code: since agents are now sent ramp rates between 0-1 user/sec, they is no longer a need for ramp rate delay logic, a function to configure agent orchestration (configureNonlinearAgentRunData()) and any other code related to the previous staggered start logic for agents. Now all agents run their own nonlinear ramp and only require a target ramp rate to do so
  • QOL UI changes: replaced user ramp rate with estimated steady state users in agent tracker and limited decimal ramp rate values to 2 decimal places
  • Added agent thread counter to help with debugging agent threads (i.e AGENT-1, AGENT-2, etc)

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review December 7, 2023 21:50
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Zakaria-Kofiro Zakaria-Kofiro merged commit e121c58 into master Dec 7, 2023
kevin-mcgoldrick added a commit that referenced this pull request Dec 10, 2023
* master:
  Nonlinear Workload - Simplify Code + QOL changes  (#291)
  Prep Snapshot 3.3.1
  Release 3.3.0
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/nonlinear-updates branch February 2, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants