fix: http links to https in README #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stationeros
reviewed
Oct 4, 2023
README.md
Outdated
| @@ -10,7 +10,7 @@ Modelled as a state machine, with the help of AWS step functions, Trapheus resto | |||
| </p> | |||
| <p align="center"><a href="https://circleci.com/gh/intuit/Trapheus"><img src="https://circleci.com/gh/intuit/Trapheus.svg?style=svg" alt="TravisCI Build Status"/></a> | |||
| <a href = "https://coveralls.io/github/intuit/Trapheus?branch=master"><img src= "https://coveralls.io/repos/github/intuit/Trapheus/badge.svg?branch=master" alt = "Coverage"/></a> | |||
| <a href="http://www.serverless.com"><img src="http://public.serverless.com/badges/v3.svg" alt="serverless badge"/></a> | |||
| <a href="https://www.serverless.com"><img src="https://public.serverless.com/badges/v3.svg" alt="serverless badge"/></a> | |||
There was a problem hiding this comment.
Can we change the "src" url to https://github.com/intuit/Trapheus/assets/112308320/c7764b65-fb72-46ed-824b-c82c6374ec8b . The current https endpoint for serverless badge is broken so i have hosted the image in this new space.
There was a problem hiding this comment.
Sure I would do that
|
Could you review my PR |
stationeros
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changed the HTTP links of
http://www.serverless.comandhttp://public.serverless.com/badges/v3.svgto HTTPS linkshttps://www.serverless.comandhttps://public.serverless.com/badges/v3.svg