ISSUE-163 adding default tags and resource tags #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 7, 2023 15:45
|
@stationeros Please review |
|
Sandip,
I will be able to get to this by Tuesday as I am out for a visa
appointments. Let me know if that works
…On Sunday, October 8, 2023, Sandip Nahak ***@***.***> wrote:
@stationeros <https://github.com/stationeros> Please review
—
Reply to this email directly, view it on GitHub
<#165 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2Y3AYB467LWDRTL3U3AXH3X6ICEHAVCNFSM6AAAAAA5W2QFIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRHA4TCNRTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
stationeros
reviewed
Oct 10, 2023
| @@ -95,6 +95,25 @@ The following are the parameters for creating the cloudformation template: | |||
|
|
|||
| [](#instructions) | |||
|
|
|||
| ## Tagging | |||
There was a problem hiding this comment.
Can this be a seperate markdown file under docs . The worry is that the readme is just increasing in size
stationeros
reviewed
Oct 10, 2023
| @@ -0,0 +1,5 @@ | |||
| version = 0.1 | |||
|
|
|||
| [default.deploy.parameters] | |||
There was a problem hiding this comment.
yes, I could create the stack using these params
Here is the AWS ref doc https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-config.html
stationeros
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the
masterbranch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.Add tags to generated lambdas #163
This will add tags at cfn stack level as well as the resource level.