Adding button to download dataset as CSV #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding button to directly download dataset as CSV
stationeros
reviewed
Oct 28, 2023
labs/TrapheusAI/trapheusai_app.py
Outdated
| @@ -98,6 +101,9 @@ def style_page(): | |||
| """ | |||
| streamlit.markdown(style, unsafe_allow_html=True) | |||
|
|
|||
| def showDownloadMessage(): | |||
| streamlit.success("Downloading dataset to system") | |||
There was a problem hiding this comment.
Can we put the message as "Your dataset has been saved"
stationeros
reviewed
Oct 28, 2023
| @@ -47,6 +47,9 @@ def handle_dataset_search(): | |||
| repository_url = data["fullurl"] | |||
| df = pd.read_csv(repository_url) | |||
| streamlit.data_editor(df) | |||
| streamlit.download_button( | |||
There was a problem hiding this comment.
Can we check if we edit the dataset and then download are the changes retained?
There was a problem hiding this comment.
It won't retain the changes but we can modify this to retain the changes if required.
There was a problem hiding this comment.
Merging this, can you open a new issue and work on saving the in memory CSV file
Updating download success prompt
stationeros
approved these changes
Oct 29, 2023
|
@bazzyadb Please star the repo for showing us some support as well |
5 tasks
|
@stationeros @namitad Can one of you please add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding button to directly download dataset as CSV
Only showing button once user selects a dataset
Using streamlit download button to download the dataset
Showing success prompt once user clicks on download button
Relevant Issues : Issue 171
Type of change :